Merging dart:html interfaces and implementations

lib/html/scripts/systemnative.py

Index: lib/html/scripts/systemnative.py
diff --git a/lib/html/scripts/systemnative.py b/lib/html/scripts/systemnative.py
index 55477de15cb4c4366b78a1a5a8615e10aebda335..7155f29183a78748b268d39ed9811e4e4bbd0a75 100644
--- a/lib/html/scripts/systemnative.py
+++ b/lib/html/scripts/systemnative.py
@@ -10,11 +10,14 @@ import emitter
 import os
 from generator import *
 from systemhtml import SecureOutputType
+from htmldartgenerator import *
 
-class DartiumBackend(object):
+class DartiumBackend(HtmlDartGenerator):
   """Generates Dart implementation for one DOM IDL interface."""
 
   def __init__(self, interface, cpp_library_emitter, options):
+    super(DartiumBackend, self).__init__(interface, options)
+
     self._interface = interface
     self._cpp_library_emitter = cpp_library_emitter
     self._database = options.database
@@ -104,9 +107,6 @@ class DartiumBackend(object):
   def RootClassName(self):
     return 'NativeFieldWrapperClass1'
 
-  def AdditionalImplementedInterfaces(self):
-    return []
-
   def NativeSpec(self):
     return ''
 
@@ -209,6 +209,20 @@ class DartiumBackend(object):
         ARGUMENTS=constructor_info.ParametersAsArgumentList(),
         NATIVE_NAME=native_binding)
 
+  def AddConstructors(self, constructors, factory_provider, class_name,
+      base_class):
+    super(DartiumBackend, self).AddConstructors(constructors, factory_provider,
+        class_name, base_class)
+
+    super_constructor = ''
+    if base_class and base_class != 'NativeFieldWrapperClass1':
+      super_constructor = ': super.internal()'

[Anton Muhin, 2012/11/02 12:55:47]

no _-prefix for an internal constructor?

[blois, 2012/11/02 19:25:28]

Yeah, I'm not thrilled about this part (and don't have a good suggestion here).
Basically once the library gets split then the constructor needs to be public
for the subclasses in other libs to call their super constructors.

It gets even more complicated with Element subclassing, where you essentially
have two constructors- a 'create a new X' and a 'wrap an instance of X'.

I was considering naming it 'wrap' rather than 'internal', but decided to call
it 'internal' for now to keep it public but send the message that it should not
be used.

I believe we'll need to revisit this with element subclassing.

[Anton Muhin, 2012/11/06 12:28:43]

I'd propose to have a private name for it until we're starting to split the
libs---it's a real security threat and I'd rather not commit it in even
temporary.

On 2012/11/02 19:25:28, blois wrote:

+
+    self._members_emitter.Emit(
+        '  $CLASSNAME.internal()$SUPERCONSTRUCTOR;\n',
+        CLASSNAME=class_name,
+        SUPERCONSTRUCTOR=super_constructor)
+
   def FinishInterface(self):
     self._GenerateCPPHeader()
 
@@ -462,6 +476,13 @@ class DartiumBackend(object):
     else:
       self._GenerateDispatcher(info.operations, dart_declaration, [info.name for info in info.param_infos])
 
+  def AddConstant(self, constant):
+    type = TypeOrNothing(self._DartType(constant.type.id), constant.type.id)
+    self._members_emitter.Emit('\n  static const $TYPE$NAME = $VALUE;\n',
+        NAME=constant.id,
+        TYPE=type,
+        VALUE=constant.value)
+
   def _GenerateDispatcher(self, operations, dart_declaration, argument_names):
 
     body = self._members_emitter.Emit(
@@ -757,8 +778,12 @@ class DartiumBackend(object):
     native_binding = '%s_%s_%s' % (self._interface.id, idl_name, native_suffix)
     self._members_emitter.Emit(
         '\n'
-        '  $DART_DECLARATION native "$NATIVE_BINDING";\n',
-        DART_DECLARATION=dart_declaration, NATIVE_BINDING=native_binding)
+        '\n  /** @domName $DOMINTERFACE.$DOMNAME */'
+        '\n  $DART_DECLARATION native "$NATIVE_BINDING";\n',
+        DOMINTERFACE=self._interface.id,
+        DOMNAME=idl_name,
+        DART_DECLARATION=dart_declaration,
+        NATIVE_BINDING=native_binding)
 
     cpp_callback_name = '%s%s' % (idl_name, native_suffix)
     self._cpp_resolver_emitter.Emit(