Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: lib/html/templates/html/impl/impl_EventTarget.darttemplate

Issue 11365019: Merging dart:html interfaces and implementations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Minor cleanup. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/html/templates/html/impl/impl_EventTarget.darttemplate
diff --git a/lib/html/templates/html/impl/impl_EventTarget.darttemplate b/lib/html/templates/html/impl/impl_EventTarget.darttemplate
index 23e8f5b9dcfbd8ca068e89ab2aee85daf7ec49b5..1a0c6e35cdac7daad3704e157b0b4a8abac06c0e 100644
--- a/lib/html/templates/html/impl/impl_EventTarget.darttemplate
+++ b/lib/html/templates/html/impl/impl_EventTarget.darttemplate
@@ -2,36 +2,35 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-class _EventsImpl implements Events {
+class Events {
/* Raw event target. */
- // TODO(jacobr): it would be nice if we could specify this as
- // _EventTargetImpl or EventTarget
+ // TODO(jacobr): it would be nice if we could specify this as EventTarget.
final _ptr;
- _EventsImpl(this._ptr);
+ Events._(this._ptr);
- _EventListenerListImpl operator [](String type) {
- return new _EventListenerListImpl(_ptr, type);
+ EventListenerList operator [](String type) {
+ return new EventListenerList._(_ptr, type);
}
}
-class _EventListenerListImpl implements EventListenerList {
+class EventListenerList {
- // TODO(jacobr): make this _EventTargetImpl
+ // TODO(jacobr): make this EventTarget
final _ptr;
final String _type;
- _EventListenerListImpl(this._ptr, this._type);
+ EventListenerList._(this._ptr, this._type);
// TODO(jacobr): implement equals.
- _EventListenerListImpl add(EventListener listener,
+ EventListenerList add(EventListener listener,
[bool useCapture = false]) {
_add(listener, useCapture);
return this;
}
- _EventListenerListImpl remove(EventListener listener,
+ EventListenerList remove(EventListener listener,
[bool useCapture = false]) {
_remove(listener, useCapture);
return this;
@@ -53,6 +52,7 @@ class _EventListenerListImpl implements EventListenerList {
class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
- Events get on => new _EventsImpl(this);
+ /** @domName EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent */
+ Events get on => new Events._(this);
$!MEMBERS
}

Powered by Google App Engine
This is Rietveld 408576698