Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1136483003: Roll WebRTC 9187:9189 (Closed)

Created:
5 years, 7 months ago by tommi (sloooow) - chröme
Modified:
5 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Include updated test expectations #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/logging_unittest.cc View 1 5 chunks +6 lines, -7 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
tommi (sloooow) - chröme
Include updated test expectations
5 years, 7 months ago (2015-05-14 02:23:57 UTC) #1
tommi (sloooow) - chröme
Hey Sergey - I need someone to take a look at the updated test expectations. ...
5 years, 7 months ago (2015-05-14 02:25:49 UTC) #3
tommi (sloooow) - chröme
https://codereview.chromium.org/1136483003/diff/20001/jingle/glue/logging_unittest.cc File jingle/glue/logging_unittest.cc (left): https://codereview.chromium.org/1136483003/diff/20001/jingle/glue/logging_unittest.cc#oldcode103 jingle/glue/logging_unittest.cc:103: ASSERT_TRUE(Initialize(rtc::LS_INFO)); rtc::LS_INFO was incorrect since rtc::LS_INFO == 3 https://codereview.chromium.org/1136483003/diff/20001/jingle/glue/logging_unittest.cc#oldcode135 ...
5 years, 7 months ago (2015-05-14 02:27:23 UTC) #4
tommi (sloooow) - chröme
Hey Sergey - I'll tbr this for now to get a day of testing before ...
5 years, 7 months ago (2015-05-14 13:13:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136483003/20001
5 years, 7 months ago (2015-05-14 13:14:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 13:19:51 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/557da2ea7e62412987275ed9f1d3684b5f5ce879 Cr-Commit-Position: refs/heads/master@{#329839}
5 years, 7 months ago (2015-05-14 13:20:46 UTC) #9
Sergey Ulanov
5 years, 7 months ago (2015-05-14 17:48:38 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698