Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: android_webview/native/aw_autofill_client.cc

Issue 1136473006: Don't autofill credit cards on non-secure pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nitpick and test run fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_autofill_client.h" 5 #include "android_webview/native/aw_autofill_client.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h" 7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_content_browser_client.h" 8 #include "android_webview/browser/aw_content_browser_client.h"
9 #include "android_webview/browser/aw_form_database_service.h" 9 #include "android_webview/browser/aw_form_database_service.h"
10 #include "android_webview/browser/aw_pref_store.h" 10 #include "android_webview/browser/aw_pref_store.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 173
174 void AwAutofillClient::OnFirstUserGestureObserved() { 174 void AwAutofillClient::OnFirstUserGestureObserved() {
175 NOTIMPLEMENTED(); 175 NOTIMPLEMENTED();
176 } 176 }
177 177
178 void AwAutofillClient::LinkClicked(const GURL& url, 178 void AwAutofillClient::LinkClicked(const GURL& url,
179 WindowOpenDisposition disposition) { 179 WindowOpenDisposition disposition) {
180 NOTIMPLEMENTED(); 180 NOTIMPLEMENTED();
181 } 181 }
182 182
183 bool AwAutofillClient::IsContextSecure(const GURL& form_origin) {
184 // TODO (sigbjorn): Return if the context is secure, not just
boliu 2015/06/30 16:20:06 Android webview can use the same implementation as
sigbjorn 2015/07/01 07:28:14 Good point. Perhaps bondd can answer this question
185 // the form_origin. See crbug.com/505390
186 return form_origin.SchemeIsCryptographic();
187 }
188
183 void AwAutofillClient::SuggestionSelected(JNIEnv* env, 189 void AwAutofillClient::SuggestionSelected(JNIEnv* env,
184 jobject object, 190 jobject object,
185 jint position) { 191 jint position) {
186 if (delegate_) { 192 if (delegate_) {
187 delegate_->DidAcceptSuggestion(suggestions_[position].value, 193 delegate_->DidAcceptSuggestion(suggestions_[position].value,
188 suggestions_[position].frontend_id, 194 suggestions_[position].frontend_id,
189 position); 195 position);
190 } 196 }
191 } 197 }
192 198
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 content::RenderFrameHost* rfh, 232 content::RenderFrameHost* rfh,
227 const ResultCallback& callback) { 233 const ResultCallback& callback) {
228 NOTIMPLEMENTED(); 234 NOTIMPLEMENTED();
229 } 235 }
230 236
231 bool RegisterAwAutofillClient(JNIEnv* env) { 237 bool RegisterAwAutofillClient(JNIEnv* env) {
232 return RegisterNativesImpl(env); 238 return RegisterNativesImpl(env);
233 } 239 }
234 240
235 } // namespace android_webview 241 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698