Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1136463009: Allow --v and --log-level switches simultaneous usage. (Closed)

Created:
5 years, 7 months ago by emaxx
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow --v and --log-level switches simultaneous usage. The current implementation, in fact, doesn't support specifying both "--v" and "--log-level" command line switches: only "--log-level" switch will take an effect. This looks counterintuitive. For example, browser_tests always start the browser with the "--log-level" switch specified, so with current implementation there's no way to enable vlogging in browser_tests using a command line. The suggestion is, as both of the options refer to the same underlying "min_log_level", to make the "--v" switch have a higher priority. BUG= Committed: https://crrev.com/0bcc7aa66844b349c70f66c4941382c0e45acfd1 Cr-Commit-Position: refs/heads/master@{#330218}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge if's. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/common/logging_chrome.cc View 1 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
emaxx
Hi Lei, please take a look at this review about the command line options.
5 years, 7 months ago (2015-05-14 00:00:27 UTC) #2
Lei Zhang
https://codereview.chromium.org/1136463009/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (right): https://codereview.chromium.org/1136463009/diff/1/chrome/common/logging_chrome.cc#newcode341 chrome/common/logging_chrome.cc:341: if (logging::GetMinLogLevel() >= 0) { Do this in the ...
5 years, 7 months ago (2015-05-14 02:31:31 UTC) #3
emaxx
https://codereview.chromium.org/1136463009/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (right): https://codereview.chromium.org/1136463009/diff/1/chrome/common/logging_chrome.cc#newcode341 chrome/common/logging_chrome.cc:341: if (logging::GetMinLogLevel() >= 0) { On 2015/05/14 02:31:31, Lei ...
5 years, 7 months ago (2015-05-15 12:59:42 UTC) #4
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-15 22:11:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136463009/20001
5 years, 7 months ago (2015-05-15 22:12:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 22:25:36 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bcc7aa66844b349c70f66c4941382c0e45acfd1
Cr-Commit-Position: refs/heads/master@{#330218}

Powered by Google App Engine
This is Rietveld 408576698