Supports multiple profile in Chrome OS IMF.

Supports multiple profile in Chrome OS IMF.

And avoid dispatching onActivate & onDeactivated events to IME
extensions if the profile is not the active profile.

BUG=485835
TEST=Verified on linux_chromeos & clapper device.

Committed: https://crrev.com/28326ecf067e03b53880186b6b861ddcd2f05a3e
Cr-Commit-Position: refs/heads/master@{#329808}

[Shu Chen, 2015-05-08 07:55:26]

shuchen@chromium.org changed reviewers:
+ alemate@chromium.org, nona@chromium.org

[Shu Chen, 2015-05-08 07:55:26]

Nona/Alexander, can you please help to review this cl? Thanks

[Shu Chen, 2015-05-08 07:56:48]

https://codereview.chromium.org/1136463005/diff/1/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1136463005/diff/1/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1012: engine =
engine_map_[ProfileManager::GetActiveUserProfile()][extension_id];
After cl https://codereview.chromium.org/1055863002/ is landed, here can use the
passed-in |profile| instead of getting the active profile.

[Shu Chen, 2015-05-09 08:31:11]

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1012: engine =
engine_map_[ProfileManager::GetActiveUserProfile()][extension_id];
After cl https://codereview.chromium.org/1055863002/ is landed, here can use the
passed-in |profile| instead of getting the active profile.

[Alexander Alekseev, 2015-05-13 17:50:39]

Thank you very much for the fix!

lgtm with a side note.

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_engine.cc (right):

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_engine.cc:508: if
(!CheckProfile())
This might be tricky, as we've seen delayed events coming after active profile
has been changed. But I do not know what actually observers do, so may be it
doesn't matter.

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1012: engine =
engine_map_[ProfileManager::GetActiveUserProfile()][extension_id];
On 2015/05/09 08:31:11, Shu Chen wrote:
> After cl https://codereview.chromium.org/1055863002/ is landed, here can use
the
> passed-in |profile| instead of getting the active profile.

It is landed now.

[Shu Chen, 2015-05-14 04:53:05]

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_engine.cc (right):

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_engine.cc:508: if
(!CheckProfile())
On 2015/05/13 17:50:38, Alexander Alekseev wrote:
> This might be tricky, as we've seen delayed events coming after active profile
> has been changed. But I do not know what actually observers do, so may be it
> doesn't matter.

Theoretically CheckProfile() here should always return true. The if-check is for
just-in-case.
And it should have no side effects.

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1136463005/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:1012: engine =
engine_map_[ProfileManager::GetActiveUserProfile()][extension_id];
On 2015/05/13 17:50:39, Alexander Alekseev wrote:
> On 2015/05/09 08:31:11, Shu Chen wrote:
> > After cl https://codereview.chromium.org/1055863002/ is landed, here can use
> the
> > passed-in |profile| instead of getting the active profile.
> 
> It is landed now.

Done.

[Shu Chen, 2015-05-14 05:01:02]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-05-14 05:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/1136463005/#ps80001
(title: "rebased.")

[commit-bot: I haz the power, 2015-05-14 05:01:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136463005/80001

[commit-bot: I haz the power, 2015-05-14 05:38:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-14 05:39:18]

Patchset 5 (id:??) landed as
https://crrev.com/28326ecf067e03b53880186b6b861ddcd2f05a3e
Cr-Commit-Position: refs/heads/master@{#329808}