Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: ppapi/shared_impl/ppb_gamepad_shared.cc

Issue 1136463002: Pass correct length value in WebGamepads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed pending comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/examples/gamepad/gamepad.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/shared_impl/ppb_gamepad_shared.h" 5 #include "ppapi/shared_impl/ppb_gamepad_shared.h"
6 6
7 #include <algorithm>
8
7 #include "base/basictypes.h" 9 #include "base/basictypes.h"
8 10
9 namespace ppapi { 11 namespace ppapi {
10 12
13 const size_t WebKitGamepads::kItemsLengthCap;
14
11 void ConvertWebKitGamepadData(const WebKitGamepads& webkit_data, 15 void ConvertWebKitGamepadData(const WebKitGamepads& webkit_data,
12 PP_GamepadsSampleData* output_data) { 16 PP_GamepadsSampleData* output_data) {
13 output_data->length = webkit_data.length; 17 size_t length = std::min(WebKitGamepads::kItemsLengthCap,
14 for (unsigned i = 0; i < webkit_data.length; ++i) { 18 static_cast<const size_t>(webkit_data.length));
19 output_data->length = static_cast<unsigned>(length);
20 for (unsigned i = 0; i < length; ++i) {
15 PP_GamepadSampleData& output_pad = output_data->items[i]; 21 PP_GamepadSampleData& output_pad = output_data->items[i];
16 const WebKitGamepad& webkit_pad = webkit_data.items[i]; 22 const WebKitGamepad& webkit_pad = webkit_data.items[i];
17 output_pad.connected = webkit_pad.connected ? PP_TRUE : PP_FALSE; 23 output_pad.connected = webkit_pad.connected ? PP_TRUE : PP_FALSE;
18 if (webkit_pad.connected) { 24 if (webkit_pad.connected) {
19 static_assert(sizeof(output_pad.id) == sizeof(webkit_pad.id), 25 static_assert(sizeof(output_pad.id) == sizeof(webkit_pad.id),
20 "id size does not match"); 26 "id size does not match");
21 memcpy(output_pad.id, webkit_pad.id, sizeof(output_pad.id)); 27 memcpy(output_pad.id, webkit_pad.id, sizeof(output_pad.id));
22 output_pad.timestamp = static_cast<double>(webkit_pad.timestamp); 28 output_pad.timestamp = static_cast<double>(webkit_pad.timestamp);
23 output_pad.axes_length = webkit_pad.axes_length; 29 output_pad.axes_length = webkit_pad.axes_length;
24 for (unsigned j = 0; j < webkit_pad.axes_length; ++j) 30 for (unsigned j = 0; j < webkit_pad.axes_length; ++j)
25 output_pad.axes[j] = static_cast<float>(webkit_pad.axes[j]); 31 output_pad.axes[j] = static_cast<float>(webkit_pad.axes[j]);
26 output_pad.buttons_length = webkit_pad.buttons_length; 32 output_pad.buttons_length = webkit_pad.buttons_length;
27 for (unsigned j = 0; j < webkit_pad.buttons_length; ++j) 33 for (unsigned j = 0; j < webkit_pad.buttons_length; ++j)
28 output_pad.buttons[j] = static_cast<float>(webkit_pad.buttons[j].value); 34 output_pad.buttons[j] = static_cast<float>(webkit_pad.buttons[j].value);
29 } 35 }
30 } 36 }
31 } 37 }
32 38
33 } // namespace ppapi 39 } // namespace ppapi
OLDNEW
« no previous file with comments | « ppapi/examples/gamepad/gamepad.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698