Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: net/ftp/ftp_network_transaction.h

Issue 11364224: FTP: Open a fresh data connection after a command error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/ftp/ftp_network_transaction.cc » ('j') | net/ftp/ftp_network_transaction.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_network_transaction.h
diff --git a/net/ftp/ftp_network_transaction.h b/net/ftp/ftp_network_transaction.h
index d5a3b9c0412c6291e7b455be321e5eb35c493630..60a802f82538941554d5d032b3ffac84723dd78c 100644
--- a/net/ftp/ftp_network_transaction.h
+++ b/net/ftp/ftp_network_transaction.h
@@ -125,6 +125,9 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction {
// Resets the members of the transaction so it can be restarted.
void ResetStateForRestart();
+ // Resets the data connection after an error and switches to |next_state|.
+ void ResetDataConnectionAfterError(State next_state);
+
void DoCallback(int result);
void OnIOComplete(int result);
@@ -249,6 +252,9 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction {
scoped_ptr<StreamSocket> data_socket_;
State next_state_;
+
+ // State to switch to after data connection is complete.
+ State state_after_data_connection_;
mmenke 2012/11/14 21:05:39 nit: Think state_after_data_connect_ would be cle
Paweł Hajdan Jr. 2012/11/14 23:30:31 Done.
};
} // namespace net
« no previous file with comments | « no previous file | net/ftp/ftp_network_transaction.cc » ('j') | net/ftp/ftp_network_transaction.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698