Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 11364197: Refactoring media controls in WebKit - side effect for Chromium: (Closed)

Created:
8 years, 1 month ago by nessy
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Refactoring media controls in WebKit - side effect for Chromium: rename of MediaControlRootElement to MediaControls. BUG=159781 WebKit bug is at: https://bugs.webkit.org/show_bug.cgi?id=88871 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
rubber stamp lgtm OOC will this cause a build break?
8 years, 1 month ago (2012-11-21 23:00:31 UTC) #1
nessy
On 2012/11/21 23:00:31, scherkus wrote: > rubber stamp lgtm > > OOC will this cause ...
8 years, 1 month ago (2012-11-21 23:05:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/silviapf@chromium.org/11364197/1
8 years, 1 month ago (2012-11-21 23:06:12 UTC) #3
commit-bot: I haz the power
Presubmit check for 11364197-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-21 23:06:14 UTC) #4
Avi (use Gerrit)
owner stamp lgtm
8 years, 1 month ago (2012-11-21 23:43:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/silviapf@chromium.org/11364197/1
8 years, 1 month ago (2012-11-21 23:43:19 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 02:02:36 UTC) #7
Change committed as 169193

Powered by Google App Engine
This is Rietveld 408576698