Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3138)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 11364184: Remove unused/not working function tracing flag and functionality. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 14749)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -20,7 +20,6 @@
DECLARE_FLAG(bool, print_ast);
DECLARE_FLAG(bool, print_scopes);
-DECLARE_FLAG(bool, trace_functions);
DECLARE_FLAG(bool, use_sse41);
DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
@@ -835,23 +834,6 @@
0); // No registers.
}
- if (FLAG_trace_functions) {
- __ pushq(RAX); // Preserve result.
- __ PushObject(Function::ZoneHandle(function.raw()));
- // We do not use GenerateCallRuntime because of the non-standard (empty)
- // stackmap used here.
- __ CallRuntime(kTraceFunctionExitRuntimeEntry);
- AddCurrentDescriptor(PcDescriptors::kOther,
- Isolate::kNoDeoptId,
- 0); // No token position.
- if (is_optimizing()) {
- stackmap_table_builder_->AddEntry(assembler()->CodeSize(),
- empty_stack_bitmap,
- 0); // No registers.
- }
- __ popq(RAX); // Remove argument.
- __ popq(RAX); // Restore result.
- }
__ LeaveFrame();
__ ret();

Powered by Google App Engine
This is Rietveld 408576698