Messages needed for webview compositor communication.

Messages needed for webview compositor communication.
Browser needs to communicate with the embedder when 
the guest renderer swaps hardware buffers.
Embedder needs to provide textures for the guest to render into.

BUG=143429
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170575

[alexst (slow to review), 2012-11-08 14:58:50]

This is just some plumbing needed by the rest of the webview compositing code.

[rjkroege, 2012-11-08 15:08:50]

lgtm with nits. But: afaik: you need a security review for adding new IPCs.

https://codereview.chromium.org/11364133/diff/11001/content/browser/browser_p...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/11364133/diff/11001/content/browser/browser_p...
content/browser/browser_plugin/browser_plugin_guest.cc:236: void
BrowserPluginGuest::SetCompositingBufferData(int gpu_process_id,
A compromised renderer process could send invalid values for these. Shouldn't
there be some sort of validation of the values?

https://codereview.chromium.org/11364133/diff/11001/content/common/browser_pl...
File content/common/browser_plugin_messages.h (right):

https://codereview.chromium.org/11364133/diff/11001/content/common/browser_pl...
content/common/browser_plugin_messages.h:304: // f accelerated buffers were
swapped in the guest, forward this
If? And more explanation for what these messages do?

[alexst (slow to review), 2012-11-08 18:12:17]

Who should I ping for a security review?

https://codereview.chromium.org/11364133/diff/11001/content/browser/browser_p...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/11364133/diff/11001/content/browser/browser_p...
content/browser/browser_plugin/browser_plugin_guest.cc:236: void
BrowserPluginGuest::SetCompositingBufferData(int gpu_process_id,
On 2012/11/08 15:08:50, rjkroege wrote:
> A compromised renderer process could send invalid values for these. Shouldn't
> there be some sort of validation of the values?

These are validated later in the TextureImageTransportSurface. If any of the
handles don't correspond to a valid object, surface creation fails.

https://codereview.chromium.org/11364133/diff/11001/content/common/browser_pl...
File content/common/browser_plugin_messages.h (right):

https://codereview.chromium.org/11364133/diff/11001/content/common/browser_pl...
content/common/browser_plugin_messages.h:304: // f accelerated buffers were
swapped in the guest, forward this
On 2012/11/08 15:08:50, rjkroege wrote:
> If? And more explanation for what these messages do?
it was actually ctrl + f to find something. Updated with better comments.

[rjkroege, 2012-11-08 18:58:59]

ken: can you security review?

[alexst (slow to review), 2012-11-14 20:37:44]

On 2012/11/08 18:58:59, rjkroege wrote:
> ken: can you security review?

Ping. Ken, please take a look at this if you have a minute.

[kenrb, 2012-11-15 21:12:55]

On 2012/11/14 20:37:44, alexst wrote:
> On 2012/11/08 18:58:59, rjkroege wrote:
> > ken: can you security review?
> 
> Ping. Ken, please take a look at this if you have a minute.

LGTM.

[alexst (slow to review), 2012-11-28 19:31:25]

On 2012/11/15 21:12:55, kenrb wrote:
> On 2012/11/14 20:37:44, alexst wrote:
> > On 2012/11/08 18:58:59, rjkroege wrote:
> > > ken: can you security review?
> > 
> > Ping. Ken, please take a look at this if you have a minute.
> 
> LGTM.

Hey guys, I made a small rearrangement by moving gpu params into creation
message instead of navigation one and added an acceleration enabled message.
Just want to make sure you are still okay with it before I click commit.

[rjkroege, 2012-11-28 20:00:51]

still lgtm for me.

[commit-bot: I haz the power, 2012-11-28 20:48:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/11364133/16007

[commit-bot: I haz the power, 2012-11-28 20:48:32]

Presubmit check for 11364133-16007 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser
    content/common/browser_plugin_messages.h

Presubmit checks took 1.2s to calculate.

[alexst (slow to review), 2012-11-28 20:59:19]

Dear OWNERS, please take a look.

[jam, 2012-11-28 22:46:42]

On 2012/11/28 20:59:19, alexst wrote:
> Dear OWNERS, please take a look.

lgtm

the browser_plugin directories in content/browser and content/renderer should
have owners of the devs working on this feature

[Cris Neckar, 2012-11-30 18:15:01]

IPC changes LGTM

[commit-bot: I haz the power, 2012-11-30 18:23:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/11364133/16007

[commit-bot: I haz the power, 2012-11-30 20:30:11]

Retried try job too often on linux_rel for step(s) content_unittests

[commit-bot: I haz the power, 2012-11-30 21:17:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/11364133/16007

[commit-bot: I haz the power, 2012-11-30 22:24:38]

Change committed as 170575