Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11364132: Revert 166464 - Turn overdraw metrics on only when about:tracing is recording. (Closed)

Created:
8 years, 1 month ago by scottmg
Modified:
8 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert 166464 - Turn overdraw metrics on only when about:tracing is recording. Now that we're in chromium, we can tell if about:tracing is enabled ot not! Turn on overdraw metrics, and their expensive computations, only when about:tracing is turned on. When we do turn them on, we don't want the performance characteristics of the system to suddenly change, or the tracing is not very meaningful! So, we track the number of pixels read, instead of written, for overdraw (which should mostly be the same with the new rasterScale feature). This computation is very cheap compared to the old one. R=jamesr BUG=119126 Review URL: https://codereview.chromium.org/11293143 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M cc/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/overdraw_metrics.cc View 4 chunks +32 lines, -10 lines 0 comments Download
M cc/quad_culler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
8 years, 1 month ago (2012-11-07 18:40:04 UTC) #1
scottmg
8 years, 1 month ago (2012-11-07 18:40:29 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698