Added support for logging the output of failed flaky tests.

tools/test-runtime.dart

Index: tools/test-runtime.dart
diff --git a/tools/test-runtime.dart b/tools/test-runtime.dart
index b9663ffe0cab54ad2933118a25332976f3ff5e89..3bcdac3fea9d116dee37f0021bc4d13c444d039e 100755
--- a/tools/test-runtime.dart
+++ b/tools/test-runtime.dart
@@ -11,6 +11,7 @@
 #library("test");
 
 #import("dart:io");
+#import("testing/dart/test_progress.dart");

[ricow1, 2012/11/08 09:49:13]

why do we need this?

[kustermann, 2012/11/08 10:24:41]

Because the FAILED_FLAKY_TESTS_LOGFILE constant is defined in the test_progress
library. Should I put the constant somewhere else?

[ricow1, 2012/11/08 10:32:51]

Alternatively put a small utility function inside the TestUtils class and use
that from both places (you already include test_suite - and this is where we get
most locations from in the remainder of the code

[kustermann, 2012/11/08 12:05:34]

Done.

 #import("testing/dart/test_runner.dart");
 #import("testing/dart/test_options.dart");
 #import("testing/dart/test_suite.dart");
@@ -50,7 +51,14 @@ main() {
   var verbose = firstConf['verbose'];
   var printTiming = firstConf['time'];
   var listTests = firstConf['list'];
-
+  var appendFlakyLog = firstConf['append_flaky_log'];

[ricow1, 2012/11/08 09:49:13]

no need to actually extract this, just use it in the conditional (we don't reuse
this to pass on to other functions)

[kustermann, 2012/11/08 10:24:41]

Done.

+  
+  if (!appendFlakyLog)  {
+    var file = new File(FAILED_FLAKY_TESTS_LOGFILE);
+    if (file.existsSync()) {
+      file.deleteSync();
+    }
+  }
   // Print the configurations being run by this execution of
   // test.dart. However, don't do it if the silent progress indicator
   // is used. This is only needed because of the junit tests.