Added support for logging the output of failed flaky tests.

tools/testing/dart/test_progress.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_progress");
 
 #import("dart:io");
 #import("test_runner.dart");
 #import("test_suite.dart");
+#import("status_file_parser.dart");
+
+const FAILED_FLAKY_TESTS_LOGFILE = ".flaky.log";

[ricow1, 2012/11/08 09:49:13]

Add comment stating explicitly what this is used for

[kustermann, 2012/11/08 10:24:41]

Done.

 
 class ProgressIndicator {
   ProgressIndicator(this._startTime, this._printTiming)
       : _tests = [], _failureSummary = [];
 
   factory ProgressIndicator.fromName(String name,
                                      Date startTime,
                                      bool printTiming) {
     switch (name) {
       case 'compact':
@@ skipping 18 matching lines @@
     }
   }
 
   void testAdded() { _foundTests++; }
 
   void start(TestCase test) {
     _printStartProgress(test);
   }
 
   void done(TestCase test) {
+    if (test.isFlaky && test.output.result != PASS) {
+      var buf = new StringBuffer();
+      for (var l in _buildFailureOutput(test)) {

[ricow1, 2012/11/08 09:49:13]

alternatively some thing like
var buf = _buildFailureOutput(test).reduce(new StringBuffer(), (p, e) =>
p.add("$e\n"));

[kustermann, 2012/11/08 10:24:41]

I think that this would not improve readability. 

+        buf.add("${l}\n");
+      }
+      _appendToFlakyFile(buf.toString());
+    }
+
     if (test.output.unexpectedOutput) {
       _failedTests++;
       _printFailureOutput(test);
     } else {
       _passedTests++;
     }
     _printDoneProgress(test);
     // If we need to print timing information we hold on to all completed
     // tests.
     if (_printTiming) _tests.add(test);
@@ skipping 55 matching lines @@
 
   String _timeString(Duration d) {
     var min = d.inMinutes;
     var sec = d.inSeconds % 60;
     return '${_padTime(min)}:${_padTime(sec)}';
   }
 
   String _header(String header) => header;
 
   void _printFailureOutput(TestCase test) {
+    var failureOutput = _buildFailureOutput(test);
+
+    for (var line in failureOutput) {
+      print(line);
+    }
+    

[ricow1, 2012/11/08 09:49:13]

remove whitespaces

[kustermann, 2012/11/08 10:24:41]

Done.

+    _failureSummary.addAll(failureOutput);
+  }
+  

[ricow1, 2012/11/08 09:49:13]

remove whitespaces

[kustermann, 2012/11/08 10:24:41]

Done.

+  List<String> _buildFailureOutput(TestCase test) {
     List<String> output = new List<String>();
     output.add('');
     output.add(_header('FAILED: ${test.configurationString}'
                        ' ${test.displayName}'));
     StringBuffer expected = new StringBuffer();
     expected.add('Expected: ');
     for (var expectation in test.expectedOutcomes) {
       expected.add('$expectation ');
     }
     output.add(expected.toString());
@@ skipping 30 matching lines @@
       for (var s in test.output.stderr) {
         output.add(s);
       }
     }
     for (Command c in test.commands) {
       output.add('');
       String message = (c == test.commands.last
           ? "Command line" : "Compilation command");
       output.add('$message: ${c.commandLine}');
     }
-    for (String line in output) {
-      print(line);
-    }
-    _failureSummary.addAll(output);
+    return output;
   }
 
   void _printFailureSummary() {
     for (String line in _failureSummary) {
       print(line);
     }
     print('');
   }
 
   void _printStatus() {
     if (_failedTests == 0) {
       print('\n===');
       print('=== All tests succeeded');
       print('===\n');
     } else {
       var pluralSuffix = _failedTests != 1 ? 's' : '';
       print('\n===');
       print('=== ${_failedTests} test$pluralSuffix failed');
       print('===\n');
     }
   }
 
+  void _appendToFlakyFile(String msg) {
+    var file = new File(FAILED_FLAKY_TESTS_LOGFILE);
+    var fd = file.openSync(FileMode.APPEND);
+    fd.writeStringSync(msg);
+    fd.closeSync();
+  }
+
   int get numFailedTests => _failedTests;
 
   int _completedTests() => _passedTests + _failedTests;
 
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
   bool _allTestsKnown = false;
   Date _startTime;
   bool _printTiming;
@@ skipping 232 matching lines @@
       print('');
       print('$config:');
       statuses.sort((a, b) => a.compareTo(b));
       for (String status in statuses) {
         print('  $status');
       }
     });
     _printStatus();
   }
 }