Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11364129: Added support for logging the output of failed flaky tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1333 matching lines...) Expand 10 before | Expand all | Expand 10 after
1344 return d8; 1344 return d8;
1345 } 1345 }
1346 1346
1347 static String vmFileName(Map configuration) { 1347 static String vmFileName(Map configuration) {
1348 var suffix = executableSuffix('vm'); 1348 var suffix = executableSuffix('vm');
1349 var vm = '${buildDir(configuration)}/dart$suffix'; 1349 var vm = '${buildDir(configuration)}/dart$suffix';
1350 ensureExists(vm, configuration); 1350 ensureExists(vm, configuration);
1351 return vm; 1351 return vm;
1352 } 1352 }
1353 1353
1354 static String flakyFileName() {
1355 // If a flaky test did fail, infos about it (i.e. test name, stdin, stdout)
ricow1 2012/11/08 12:28:50 s/infos/info
1356 // will be written to this file. This is useful for the debugging of
ricow1 2012/11/08 12:28:50 This is useful for debugging flaky tests.
1357 // flaky tests.
1358 // When running on a built bot, the file can be made visible in the waterfal l UI.
ricow1 2012/11/08 12:28:50 Long line
ricow1 2012/11/08 12:28:50 s/built bot/buildbot
1359 return ".flaky.log";
ahe 2012/11/09 10:35:02 I suggest that you remove the first dot.
1360 }
1361
1354 static void ensureExists(String filename, Map configuration) { 1362 static void ensureExists(String filename, Map configuration) {
1355 if (!configuration['list'] && !(new File(filename).existsSync())) { 1363 if (!configuration['list'] && !(new File(filename).existsSync())) {
1356 throw "Executable '$filename' does not exist"; 1364 throw "Executable '$filename' does not exist";
1357 } 1365 }
1358 } 1366 }
1359 1367
1360 static String compilerPath(Map configuration) { 1368 static String compilerPath(Map configuration) {
1361 if (configuration['compiler'] == 'none') { 1369 if (configuration['compiler'] == 'none') {
1362 return null; // No separate compiler for dartium tests. 1370 return null; // No separate compiler for dartium tests.
1363 } 1371 }
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1493 * $pass tests are expected to pass 1501 * $pass tests are expected to pass
1494 * $failOk tests are expected to fail that we won't fix 1502 * $failOk tests are expected to fail that we won't fix
1495 * $fail tests are expected to fail that we should fix 1503 * $fail tests are expected to fail that we should fix
1496 * $crash tests are expected to crash that we should fix 1504 * $crash tests are expected to crash that we should fix
1497 * $timeout tests are allowed to timeout 1505 * $timeout tests are allowed to timeout
1498 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1506 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1499 """; 1507 """;
1500 print(report); 1508 print(report);
1501 } 1509 }
1502 } 1510 }
OLDNEW
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698