Added support for logging the output of failed flaky tests.

tools/testing/dart/test_progress.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_progress");
 
 #import("dart:io");
 #import("test_runner.dart");
 #import("test_suite.dart");
+#import("status_file_parser.dart");
+
+const FAILED_FLAKY_TESTS_LOGFILE = "failed_flaky_tests.log";
 
 class ProgressIndicator {
   ProgressIndicator(this._startTime, this._printTiming)
       : _tests = [], _failureSummary = [];
 
   factory ProgressIndicator.fromName(String name,
                                      Date startTime,
                                      bool printTiming) {
     switch (name) {
       case 'compact':
@@ skipping 18 matching lines @@
     }
   }
 
   void testAdded() { _foundTests++; }
 
   void start(TestCase test) {
     _printStartProgress(test);
   }
 
   void done(TestCase test) {
+    if (test.isExpectedToBeFlaky() && test.output.result != PASS) {
+      var report = new StringBuffer();

[ricow1, 2012/11/07 19:56:51]

extract the body of this conditional into a separate function

[kustermann, 2012/11/08 09:15:13]

I refactored this instead

+      report.add("Flaky test ${test.displayName} failed: \n");

[ricow1, 2012/11/07 19:56:51]

How about refactoring _printFailureOutput to call another function that actually
produces the string to print out and then also call that function from here.
That way we ensure that we always get the same output from a failing test no
matter if it is flaky or not? (there are info here that is not printed that we
print in _printFailureOutput)
If you do that, then please ignore the comment above about moving out 

[kustermann, 2012/11/08 09:15:13]

Done.

+      report.add("--------------------------------------------------\n");
+      report.add("stdout of ${test.displayName} was:\n");
+      for (var s in test.output.stdout) {
+        report.add("  $s\n");
+      }
+      report.add("\n");
+      report.add("stderr of ${test.displayName} was:\n");
+      for (var s in test.output.stderr) {
+        report.add("  $s\n");
+      }
+      report.add("\n\n");
+      appendToFlakyFile(report.toString());
+    }
+
     if (test.output.unexpectedOutput) {
       _failedTests++;
       _printFailureOutput(test);
     } else {
       _passedTests++;
     }
     _printDoneProgress(test);
     // If we need to print timing information we hold on to all completed
     // tests.
     if (_printTiming) _tests.add(test);
@@ skipping 131 matching lines @@
       print('=== All tests succeeded');
       print('===\n');
     } else {
       var pluralSuffix = _failedTests != 1 ? 's' : '';
       print('\n===');
       print('=== ${_failedTests} test$pluralSuffix failed');
       print('===\n');
     }
   }
 
+  void appendToFlakyFile(String msg) {
+    var file = new File(FAILED_FLAKY_TESTS_LOGFILE);
+    var fd = file.openSync(FileMode.APPEND);
+    fd.writeStringSync(msg);
+    fd.closeSync();
+  }
+
   int get numFailedTests => _failedTests;
 
   int _completedTests() => _passedTests + _failedTests;
 
   int _foundTests = 0;
   int _passedTests = 0;
   int _failedTests = 0;
   bool _allTestsKnown = false;
   Date _startTime;
   bool _printTiming;
@@ skipping 232 matching lines @@
       print('');
       print('$config:');
       statuses.sort((a, b) => a.compareTo(b));
       for (String status in statuses) {
         print('  $status');
       }
     });
     _printStatus();
   }
 }