Issue 11364105: Fix dirname logic for msys and not-msys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11364105: Fix dirname logic for msys and not-msys. (Closed)

Created:
8 years, 1 month ago by szager1

Modified:
6 years, 9 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Fix dirname logic for msys and not-msys. TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166284

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	git-cl	View		1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iannucci

6 years, 9 months ago (2014-03-06 02:15:46 UTC) #3

Message was sent while issue was closed.

Do either of you remember what you were trying to fix here?

I'm actually rather doubtful that this is necessary, given that msysgit ships
with dirname.

Expand Messages | Collapse Messages