Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: net/quic/quic_client_session_test.cc

Issue 11364068: Add a QuicHttpStream class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bugs Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_client_session_test.cc
diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc
index e811648f57a844153fff713f5a2fa443e5a710bb..4d47731e36d1a626c8588b2b04747080a12992fc 100644
--- a/net/quic/quic_client_session_test.cc
+++ b/net/quic/quic_client_session_test.cc
@@ -60,17 +60,14 @@ TEST_F(QuicClientSessionTest, MaxNumConnections) {
std::vector<QuicReliableClientStream*> streams;
for (size_t i = 0; i < kDefaultMaxStreamsPerConnection; i++) {
QuicReliableClientStream* stream = session_.CreateOutgoingReliableStream();
- streams.push_back(stream);
EXPECT_TRUE(stream);
+ streams.push_back(stream);
}
EXPECT_FALSE(session_.CreateOutgoingReliableStream());
// Close a stream and ensure I can now open a new one.
session_.CloseStream(streams[0]->id());
- scoped_ptr<QuicReliableClientStream> stream(
- session_.CreateOutgoingReliableStream());
- EXPECT_TRUE(stream.get());
- STLDeleteElements(&streams);
+ EXPECT_TRUE(session_.CreateOutgoingReliableStream());
willchan no longer on Chromium 2012/11/21 22:50:03 Is this just leaking?
Ryan Hamilton 2012/11/21 23:06:35 No, the stream is owned by the session.
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698