make StackingClient dispatch to either ash or desktop

Currently, the ash and desktop implementations of StackingClient stomp each other in aura::Env. Instead:

- Don't have StackingClient implementations install themselves by default
- Add chrome implementation of StackingClient that dispatches to ash or desktop
- Pass extra |context| to GetDefaultParent (normally a RootWindow) that it can use to determine desktop type.
- Workaround a few locations by using ScopedForceDesktopType: in these locations, the GetHostDesktopForNative... functions fail because they're used during window creation when the windows have no parent (and so can't determine which desktop they're in).
- Remove window-specific StackingClient (unnecessary?)

BUG=128578
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167245

[Ben Goodger (Google), 2012-11-12 16:49:32]

Good stuff.

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:241: // get a valid parent window
here.
grammar

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/chro...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/chro...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:45:
stacking_client_.reset(new StackingClientAuraWin);
is there any reason we can't use this on windows too? it doesn't look inherently
windows specific. i'd rather keep this code as cross-platform as possible.

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/stac...
File chrome/browser/ui/aura/stacking_client_aurawin.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/stac...
chrome/browser/ui/aura/stacking_client_aurawin.cc:24: if
(chrome::GetHostDesktopTypeForNativeView(context) ==
on linux this will only ever return HDT_NATIVE right now, but that's fine.

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame.cc:67: #if defined(USE_ASH)
can we make this USE_AURA?

http://codereview.chromium.org/11364053/diff/7044/ui/aura/client/stacking_cli...
File ui/aura/client/stacking_client.h (right):

http://codereview.chromium.org/11364053/diff/7044/ui/aura/client/stacking_cli...
ui/aura/client/stacking_client.h:26: // going to be immediately added.
document |context|.

http://codereview.chromium.org/11364053/diff/7044/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

http://codereview.chromium.org/11364053/diff/7044/ui/views/widget/widget.h#ne...
ui/views/widget/widget.h:194: gfx::NativeView context;
document.

[scottmg, 2012-11-12 18:03:53]

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_manager.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_manager.cc:241: // get a valid parent window
here.
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> grammar

Done.

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/chro...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/chro...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:45:
stacking_client_.reset(new StackingClientAuraWin);
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> is there any reason we can't use this on windows too? it doesn't look
inherently
> windows specific. i'd rather keep this code as cross-platform as possible.

Done. ("can't use this on linux too?" i assume)

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/stac...
File chrome/browser/ui/aura/stacking_client_aurawin.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/aura/stac...
chrome/browser/ui/aura/stacking_client_aurawin.cc:24: if
(chrome::GetHostDesktopTypeForNativeView(context) ==
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> on linux this will only ever return HDT_NATIVE right now, but that's fine.

Right, yeah. So, should be OK to be just StackingClientAura instead like you
say.

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame.cc:67: #if defined(USE_ASH)
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> can we make this USE_AURA?

Done.

http://codereview.chromium.org/11364053/diff/7044/ui/aura/client/stacking_cli...
File ui/aura/client/stacking_client.h (right):

http://codereview.chromium.org/11364053/diff/7044/ui/aura/client/stacking_cli...
ui/aura/client/stacking_client.h:26: // going to be immediately added.
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> document |context|.

Done.

http://codereview.chromium.org/11364053/diff/7044/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

http://codereview.chromium.org/11364053/diff/7044/ui/views/widget/widget.h#ne...
ui/views/widget/widget.h:194: gfx::NativeView context;
On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> document.

Done.

[scottmg, 2012-11-12 18:20:30]

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame.cc:67: #if defined(USE_ASH)
On 2012/11/12 18:03:53, scottmg wrote:
> On 2012/11/12 16:49:33, Ben Goodger (Google) wrote:
> > can we make this USE_AURA?
> 
> Done.

Oops, USE_AURA doesn't work on linux_aura. I'm not sure if there's a better way
to get an ash window without an ash:: here?

[Ben Goodger (Google), 2012-11-12 18:26:24]

lgtm

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

http://codereview.chromium.org/11364053/diff/7044/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame.cc:67: #if defined(USE_ASH)
hrm. I guess we're not building ash yet on linux. use_ash is fine then.

[commit-bot: I haz the power, 2012-11-12 20:32:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/11364053/7055