Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2592)

Unified Diff: ash/wm/workspace/workspace_window_resizer_unittest.cc

Issue 11364052: Revert "Disabled WorkspaceWindowResizerTest.Edge since it got broken by https://chromiumcodereview.… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_window_resizer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_window_resizer_unittest.cc
diff --git a/ash/wm/workspace/workspace_window_resizer_unittest.cc b/ash/wm/workspace/workspace_window_resizer_unittest.cc
index eb2ed5e5f7f51a2f1ec1b03bbf79cae6ed897431..969ad1f4bcb4c8bf632afd49d244e23630f30144 100644
--- a/ash/wm/workspace/workspace_window_resizer_unittest.cc
+++ b/ash/wm/workspace/workspace_window_resizer_unittest.cc
@@ -457,9 +457,7 @@ TEST_F(WorkspaceWindowResizerTest, AttachedResize_BOTTOM_3_Compress) {
}
// Assertions around dragging to the left/right edge of the screen.
-// TODO(phoglund): Re-enable once breakage from
-// https://chromiumcodereview.appspot.com/11369017 gets fixed.
-TEST_F(WorkspaceWindowResizerTest, DISABLED_Edge) {
+TEST_F(WorkspaceWindowResizerTest, Edge) {
int bottom =
ScreenAsh::GetDisplayWorkAreaBoundsInParent(window_.get()).bottom();
window_->SetBounds(gfx::Rect(20, 30, 50, 60));
@@ -476,43 +474,15 @@ TEST_F(WorkspaceWindowResizerTest, DISABLED_Edge) {
GetRestoreBoundsInScreen(window_.get())->ToString());
}
// Try the same with the right side.
- {
- scoped_ptr<WorkspaceWindowResizer> resizer(WorkspaceWindowResizer::Create(
- window_.get(), gfx::Point(), HTCAPTION, empty_windows()));
- ASSERT_TRUE(resizer.get());
- resizer->Drag(CalculateDragPoint(*resizer, 800, 10), 0);
- resizer->CompleteDrag(0);
- EXPECT_EQ("80,0 720x" + base::IntToString(bottom),
- window_->bounds().ToString());
- ASSERT_TRUE(GetRestoreBoundsInScreen(window_.get()));
- EXPECT_EQ("20,30 50x60",
- GetRestoreBoundsInScreen(window_.get())->ToString());
- }
-
- // Test if the restore bounds is correct in multiple displays.
- ClearRestoreBounds(window_.get());
- UpdateDisplay("800x600,200x600");
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
- EXPECT_EQ(root_windows[0], window_->GetRootWindow());
- window_->SetBoundsInScreen(gfx::Rect(800, 10, 50, 60),
- ScreenAsh::GetSecondaryDisplay());
- EXPECT_EQ(root_windows[1], window_->GetRootWindow());
- {
- bottom =
- ScreenAsh::GetDisplayWorkAreaBoundsInParent(window_.get()).bottom();
- EXPECT_EQ("800,10 50x60", window_->GetBoundsInScreen().ToString());
-
- scoped_ptr<WorkspaceWindowResizer> resizer(WorkspaceWindowResizer::Create(
- window_.get(), gfx::Point(), HTCAPTION, empty_windows()));
- ASSERT_TRUE(resizer.get());
-
- resizer->Drag(CalculateDragPoint(*resizer, 199, 00), 0);
- resizer->CompleteDrag(0);
- EXPECT_EQ("20,0 180x" + base::IntToString(bottom),
- window_->bounds().ToString());
- EXPECT_EQ("800,10 50x60",
- GetRestoreBoundsInScreen(window_.get())->ToString());
- }
+ scoped_ptr<WorkspaceWindowResizer> resizer(WorkspaceWindowResizer::Create(
+ window_.get(), gfx::Point(), HTCAPTION, empty_windows()));
+ ASSERT_TRUE(resizer.get());
+ resizer->Drag(CalculateDragPoint(*resizer, 800, 10), 0);
+ resizer->CompleteDrag(0);
+ EXPECT_EQ("80,0 720x" + base::IntToString(bottom),
+ window_->bounds().ToString());
+ ASSERT_TRUE(GetRestoreBoundsInScreen(window_.get()));
+ EXPECT_EQ("20,30 50x60", GetRestoreBoundsInScreen(window_.get())->ToString());
}
// Verifies a window can be moved from the primary display to another.
« no previous file with comments | « ash/wm/workspace/workspace_window_resizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698