Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 11364008: cc: Update README file. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Update README file. Remove old instructions. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M cc/README View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 1 month ago (2012-10-31 16:20:31 UTC) #1
jamesr
8 years, 1 month ago (2012-10-31 16:47:21 UTC) #2
lgtm thanks
On Oct 31, 2012 9:20 AM, <tfarina@chromium.org> wrote:

> Reviewers: jamesr,
>
> Description:
> cc: Update README file.
>
> Remove old instructions.
>
> R=jamesr@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/11364008/<http://codereview.chromium.org/113...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M cc/README
>
>
> Index: cc/README
> diff --git a/cc/README b/cc/README
> index 7b94aea4e977f0be6d9efe89c377cd**a5f195c5fd..**
> 1696a191a295ad1a51479fa16f8f8d**bb08db4623 100644
> --- a/cc/README
> +++ b/cc/README
> @@ -1,15 +1,4 @@
> -This is the chromium compositor implementation. Currently it's in state of
> -transition from the WebKit repository to chromium, so there are only stubs
> -here that are not compiled in by default.
> -
> -To try this out, do the following:
> -
> -0.) Run the 'copyfiles.py' script in this directory to sync the cc files
> from
> -    their current location in WebKit into this directory.
> -1.) Set the gyp variable 'use_libcc_for_compositor=1' and run gyp:
> -    ./build/gyp_chromium -Duse_libcc_for_compositor=1
> -2.) Build the 'cc' target to build just the compositor library, or build
> -    'cc_unittests' for the unit tests.
> +This is the chromium compositor implementation.
>
>  Notes about the component=shared_library build:
>  Because the compositor currently depends on non-exported symbols from
> inside
>
>
>

Powered by Google App Engine
This is Rietveld 408576698