Issue 1136383004: Add test for Issue 23432

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136383004: Add test for Issue 23432 (Closed)

Created:
5 years, 7 months ago by sra1

Modified:
5 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add test for Issue 23432 BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=45821 Committed: https://code.google.com/p/dart/source/detail?r=45824

Patch Set 2 : address code review comments #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tests/compiler/dart2js_extra/23432_test.dart	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/1136383004/diff/1/tests/compiler/dart2js_extra/23432_test.dart File tests/compiler/dart2js_extra/23432_test.dart (right): https://codereview.chromium.org/1136383004/diff/1/tests/compiler/dart2js_extra/23432_test.dart#newcode5 tests/compiler/dart2js_extra/23432_test.dart:5: // Regression test for http://dartbug.com/23432 let's add a ...

5 years, 7 months ago (2015-05-14 23:23:05 UTC) #3

sra1

Committed patchset #1 (id:1) manually as 45821 (presubmit successful).

5 years, 7 months ago (2015-05-15 19:59:37 UTC) #4

sra1

5 years, 7 months ago (2015-05-15 20:31:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45824 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1136383004: Add test for Issue 23432 (Closed)

Description

Patch Set 1 #

Patch Set 2 : address code review comments #

Messages