Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: content/browser/appcache/appcache_disk_cache.h

Issue 1136373003: AppCache: Ensure inflight ActiveCalls are not destroyed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win build failures Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/appcache/appcache_disk_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_disk_cache.h
diff --git a/content/browser/appcache/appcache_disk_cache.h b/content/browser/appcache/appcache_disk_cache.h
index 8995e83cf719db91571925f8437a078cbbcf88a1..d4a7723423f1a47aa895a5c217208e06f59f73c3 100644
--- a/content/browser/appcache/appcache_disk_cache.h
+++ b/content/browser/appcache/appcache_disk_cache.h
@@ -96,8 +96,6 @@ class CONTENT_EXPORT AppCacheDiskCache
const scoped_refptr<base::SingleThreadTaskRunner>& cache_thread,
const net::CompletionCallback& callback);
void OnCreateBackendComplete(int rv);
- void AddActiveCall(ActiveCall* call) { active_calls_.insert(call); }
- void RemoveActiveCall(ActiveCall* call) { active_calls_.erase(call); }
void AddOpenEntry(EntryImpl* entry) { open_entries_.insert(entry); }
void RemoveOpenEntry(EntryImpl* entry) { open_entries_.erase(entry); }
@@ -105,9 +103,10 @@ class CONTENT_EXPORT AppCacheDiskCache
net::CompletionCallback init_callback_;
scoped_refptr<CreateBackendCallbackShim> create_backend_callback_;
PendingCalls pending_calls_;
- ActiveCalls active_calls_;
OpenEntries open_entries_;
scoped_ptr<disk_cache::Backend> disk_cache_;
+
+ base::WeakPtrFactory<AppCacheDiskCache> weak_factory_;
};
} // namespace content
« no previous file with comments | « no previous file | content/browser/appcache/appcache_disk_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698