Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1136363003: Remove AppListMixer field trial. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-mixer-priority-finch-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AppListMixer field trial. Now hard-coded the new Blended behaviour, which ranks app list results by their score, rather than stratifying them into groups. BUG=487494 Committed: https://crrev.com/73b851c4a2a52d3a75616e202e3278e3da18ac7e Cr-Commit-Position: refs/heads/master@{#405084}

Patch Set 1 #

Patch Set 2 : Remove flags. #

Patch Set 3 : Rebase. #

Patch Set 4 : Don't remove histograms. #

Patch Set 5 : Fix MixerTest. #

Patch Set 6 : Rebase. #

Total comments: 1

Patch Set 7 : Remove old comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -269 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 2 4 chunks +8 lines, -15 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/app_list/search/mixer.h View 1 2 2 chunks +7 lines, -27 lines 0 comments Download
M ui/app_list/search/mixer.cc View 1 2 3 4 5 6 8 chunks +36 lines, -138 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 1 2 3 4 11 chunks +32 lines, -57 lines 0 comments Download
M ui/app_list/search_controller.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M ui/app_list/search_controller.cc View 1 2 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Matt Giuca
4 years, 5 months ago (2016-07-07 03:50:09 UTC) #3
calamity
lgtm https://codereview.chromium.org/1136363003/diff/100001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/1136363003/diff/100001/ui/app_list/search/mixer.cc#newcode22 ui/app_list/search/mixer.cc:22: // "Blended". Update comment.
4 years, 5 months ago (2016-07-13 06:57:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1136363003/120001
4 years, 5 months ago (2016-07-13 07:52:01 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-13 08:40:40 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 08:40:51 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:42:43 UTC) #12
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/73b851c4a2a52d3a75616e202e3278e3da18ac7e
Cr-Commit-Position: refs/heads/master@{#405084}

Powered by Google App Engine
This is Rietveld 408576698