Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1136353002: Convert Media Router WebUI <button>s to <paper-button>s. (Closed)

Created:
5 years, 7 months ago by apacible
Modified:
5 years, 7 months ago
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Media Router WebUI <button>s to <paper-button>s. Committed: https://crrev.com/c762a67bdd7d3f65446fba86eabc36c8646e44aa Cr-Commit-Position: refs/heads/master@{#329880}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -27 lines) Patch
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.css View 1 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/resources/media_router/elements/issue_banner/issue_banner.html View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/media_router/elements/route_details/route_details.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/media_router/media_router_common.css View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
apacible
PTAL, thanks! Route Details: - LTR: https://screenshot.googleplex.com/CLGJ2W1Lhaw.png - RTL: https://screenshot.googleplex.com/DC3X9r32qzv.png Issues (1 action): - LTR: ...
5 years, 7 months ago (2015-05-13 01:35:55 UTC) #4
mark a. foltz
It seems like we are adding some of our own styling to the paper buttons. ...
5 years, 7 months ago (2015-05-13 01:50:32 UTC) #5
Jeremy Klein
lgtm https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css File chrome/browser/resources/media_router/media_router_common.css (right): https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css#newcode6 chrome/browser/resources/media_router/media_router_common.css:6: background-color: rgb(238, 238, 238); On 2015/05/13 01:50:32, mark ...
5 years, 7 months ago (2015-05-13 02:28:15 UTC) #6
apacible
https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css File chrome/browser/resources/media_router/media_router_common.css (right): https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css#newcode6 chrome/browser/resources/media_router/media_router_common.css:6: background-color: rgb(238, 238, 238); These are current placeholder colors, ...
5 years, 7 months ago (2015-05-13 14:31:18 UTC) #7
mark a. foltz
lgtm On 2015/05/13 14:31:18, apacible wrote: > https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css > File chrome/browser/resources/media_router/media_router_common.css (right): > > https://codereview.chromium.org/1136353002/diff/1/chrome/browser/resources/media_router/media_router_common.css#newcode6 ...
5 years, 7 months ago (2015-05-13 18:08:59 UTC) #8
apacible
On 2015/05/13 18:08:59, mark a. foltz wrote: > lgtm > > On 2015/05/13 14:31:18, apacible ...
5 years, 7 months ago (2015-05-14 16:56:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136353002/20001
5 years, 7 months ago (2015-05-14 17:06:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 18:23:34 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 18:25:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c762a67bdd7d3f65446fba86eabc36c8646e44aa
Cr-Commit-Position: refs/heads/master@{#329880}

Powered by Google App Engine
This is Rietveld 408576698