Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1136343002: Remove blink_tests target. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove blink_tests target. We need to have a single target called 'blink_tests' to avoid name collision in the GN build. Because of that it was decided to keep the Chromium's and remove this one in Blink. BUG=483171 TEST=build/gyp_chromium && gn gen out-gn/Debug R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M public/BUILD.gn View 1 chunk +1 line, -9 lines 0 comments Download
M public/all.gyp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
Depends on https://codereview.chromium.org/1129653004/
5 years, 7 months ago (2015-05-13 00:15:53 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-13 00:39:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136343002/1
5 years, 7 months ago (2015-05-14 14:38:49 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 16:01:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195357

Powered by Google App Engine
This is Rietveld 408576698