Issue 113633005: Cancel load event on a failed image resource fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113633005: Cancel load event on a failed image resource fetch. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
Nate Chapin, abarth-chromium

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Cancel load event on a failed image resource fetch. If the image loader is notified of a resource that finished loading with an error, make sure the pending load event is cancelled and an error event is dispatched in its stead. R= BUG=324417 TEST=http/tests/misc/image-onerror-no-load-event Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164111

Patch Set 1 #

Patch Set 2 : Add test for broken images #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -0 lines)			Patch
A	LayoutTests/http/tests/misc/image-onerror-no-load-event.html	View	1	1 chunk	+64 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/misc/image-onerror-no-load-event-expected.txt	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/loader/ImageLoader.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/113633005/20001

7 years ago (2013-12-18 17:46:14 UTC) #3

Message was sent while issue was closed.

Change committed as 164111

Expand Messages | Collapse Messages