sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart - Issue 11363252: Extend Iterable instead of implementing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

Issue 11363252: Extend Iterable instead of implementing it. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Address Stephen's comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/tree/dartstring.dart » ('j') | sdk/lib/utf/utf16.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart b/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

index cede225be99a109917dbbcaa04c9047e58434ebd..cb61989f406a311f5dc2f0a40f01e0e0304016d5 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dart

@@ -53,7 +53,7 @@ LibraryMirror findLibrary(MemberMirror member) {

throw new Exception('Unexpected owner: ${owner}');

}

-class HierarchyIterable implements Iterable<ClassMirror> {

+class HierarchyIterable extends Iterable<ClassMirror> {

final bool includeType;

final ClassMirror type;