sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart - Issue 11363252: Extend Iterable instead of implementing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

Issue 11363252: Extend Iterable instead of implementing it. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Address Stephen's comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

index d5aede5f0f741d164e6b6b028ea0ab334743f514..5a6eb171c50dc0031485d941d2e6d215c13a6751 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

@@ -120,7 +120,7 @@ class _MatchImplementation implements Match {

}

-class _AllMatchesIterable implements Iterable<Match> {

+class _AllMatchesIterable extends Iterable<Match> {

final JSSyntaxRegExp _re;

final String _str;