Allow Chrome apps to create Ash Panels (apps v2)

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "base/command_line.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/browser/debugger/devtools_window.h"
@@ skipping 15 matching lines @@
 namespace app_window = extensions::api::app_window;
 namespace Create = app_window::Create;
 
 namespace extensions {
 
 namespace app_window_constants {
 const char kInvalidWindowId[] =
     "The window id can not be more than 256 characters long.";
 }
 
+const char kPanelTypeOption[] = "panel";
 const char kNoneFrameOption[] = "none";
 const char kHtmlFrameOption[] = "experimental-html";
 
 namespace {
 
 // Opens an inspector window and delays the response to the
 // AppWindowCreateFunction until the DevToolsWindow has finished loading, and is
 // ready to stop on breakpoints in the callback.
 class DevToolsRestorer : public content::NotificationObserver {
  public:
@@ skipping 91 matching lines @@
       if (bounds->width.get())
         create_params.bounds.set_width(*bounds->width.get());
       if (bounds->height.get())
         create_params.bounds.set_height(*bounds->height.get());
       if (bounds->left.get())
         create_params.bounds.set_x(*bounds->left.get());
       if (bounds->top.get())
         create_params.bounds.set_y(*bounds->top.get());
     }
 
+    if (options->type.get()) {
+      if (*options->type == kPanelTypeOption)
+        create_params.window_type = ShellWindow::WINDOW_TYPE_PANEL;

[jeremya, 2012/11/29 02:49:05]

If these panels are only allowed for Talk, we should throw an exception here. Is
that the case?

[stevenjb, 2012/11/29 03:11:26]

In apps v2 panels are not intended to be restricted to Talk, but initially they
should be behind the experimental flag, will add that.

+    }
+
     if (options->frame.get()) {
       if (*options->frame == kHtmlFrameOption &&
           CommandLine::ForCurrentProcess()->HasSwitch(
               switches::kEnableExperimentalExtensionApis)) {
-        create_params.frame = ShellWindow::CreateParams::FRAME_NONE;
+        create_params.frame = ShellWindow::FRAME_NONE;
         inject_html_titlebar = true;
       } else if (*options->frame == kNoneFrameOption) {
-        create_params.frame = ShellWindow::CreateParams::FRAME_NONE;
+        create_params.frame = ShellWindow::FRAME_NONE;
       } else {
-        create_params.frame = ShellWindow::CreateParams::FRAME_CHROME;
+        create_params.frame = ShellWindow::FRAME_CHROME;
       }
     }
 
     gfx::Size& minimum_size = create_params.minimum_size;
     if (options->min_width.get())
       minimum_size.set_width(*options->min_width);
     if (options->min_height.get())
       minimum_size.set_height(*options->min_height);
     gfx::Size& maximum_size = create_params.maximum_size;
     if (options->max_width.get())
@@ skipping 54 matching lines @@
   if (ShellWindowRegistry::Get(profile())->HadDevToolsAttached(created_view)) {
     new DevToolsRestorer(this, created_view);
     return true;
   }
 
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions