Allow Chrome apps to create Ash Panels (apps v2)

ash/wm/frame_painter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/frame_painter.h"
 
 #include "ash/ash_constants.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/property_util.h"
@@ skipping 474 matching lines @@
                                                gfx::Canvas* canvas) {
   // Paint the line just above the content area.
   gfx::Rect client_bounds = view->GetBoundsForClientView();
   canvas->FillRect(gfx::Rect(client_bounds.x(),
                              client_bounds.y() - kHeaderContentSeparatorSize,
                              client_bounds.width(),
                              kHeaderContentSeparatorSize),
                    kHeaderContentSeparatorColor);
 }
 
-int FramePainter::HeaderContentSeparatorSize() const {
-  return kHeaderContentSeparatorSize;
+int FramePainter::HeaderHeight() const {
+  int bottom_y = std::max(size_button_->bounds().bottom(),
+                          close_button_->bounds().bottom());
+  return (bottom_y - 1) + kHeaderContentSeparatorSize;

[James Cook, 2012/11/20 22:08:41]

nit: Consider documenting that the -1 is because the art is created so the
bottom pixel overlaps the separator line.

 }
 
 void FramePainter::PaintTitleBar(views::NonClientFrameView* view,
                                  gfx::Canvas* canvas,
                                  const gfx::Font& title_font) {
   // The window icon is painted by its own views::View.
   views::WidgetDelegate* delegate = frame_->widget_delegate();
   if (delegate && delegate->ShouldShowWindowTitle()) {
     gfx::Rect title_bounds = GetTitleBounds(view, title_font);
     canvas->DrawStringInt(delegate->GetWindowTitle(),
@@ skipping 347 matching lines @@
   int title_y =
       (view->GetBoundsForClientView().y() - title_font.GetHeight()) / 2;
   return gfx::Rect(
       title_x,
       std::max(0, title_y),
       std::max(0, size_button_->x() - kTitleLogoSpacing - title_x),
       title_font.GetHeight());
 }
 
 }  // namespace ash