Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 11363222: Persist download interrupt reason, both target and current paths, and url_chain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Ben's comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index 723dd4e6b64ceb1672791133f855e299154378c0..8ef4d86cb13e9cd917f489cec6978fdc1ee5c5b5 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -148,13 +148,18 @@ bool DownloadStoredProperly(
// This function may be called multiple times for a given test. Returning
// false doesn't necessarily mean that the test has failed or will fail, it
// might just mean that the test hasn't passed yet.
- if (info.path != expected_path) {
- VLOG(20) << __FUNCTION__ << " " << info.path.value()
+ if (info.target_path != expected_path) {
+ VLOG(20) << __FUNCTION__ << " " << info.target_path.value()
<< " != " << expected_path.value();
return false;
}
- if (info.url != expected_url) {
- VLOG(20) << __FUNCTION__ << " " << info.url.spec()
+ if (info.url_chain.size() != 1u) {
+ VLOG(20) << __FUNCTION__ << " " << info.url_chain.size()
+ << " != 1";
+ return false;
+ }
+ if (info.url_chain[0] != expected_url) {
+ VLOG(20) << __FUNCTION__ << " " << info.url_chain[0].spec()
<< " != " << expected_url.spec();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698