chrome/browser/extensions/api/downloads/downloads_api_unittest.cc - Issue 11363222: Persist download interrupt reason, both target and current paths, and url_chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

Issue 11363222: Persist download interrupt reason, both target and current paths, and url_chain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added test requested by reviewers. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/history/download_database.h » ('j') | chrome/browser/history/history_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

index 702d89ebc291b542148129a5a750981d75347591..8fb6fd0624b5374c0e5d8183dd8456c9aa876d87 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

@@ -359,13 +359,17 @@ class DownloadExtensionTest : public ExtensionApiTest {

base::Time current = base::Time::Now();

std::vector<DownloadPersistentStoreInfo> entries;

entries.reserve(count);

+ std::vector<GURL> url_chain;

+ url_chain.push_back(GURL());

for (size_t i = 0; i < count; ++i) {

DownloadPersistentStoreInfo entry(

downloads_directory().Append(history_info[i].filename),

- GURL(), GURL(), // URL, referrer

+ downloads_directory().Append(history_info[i].filename),

+ url_chain, GURL(), // URL Chain, referrer

current, current, // start_time, end_time

1, 1, // received_bytes, total_bytes

history_info[i].state, // state

+ content::DOWNLOAD_INTERRUPT_REASON_NONE,

i + 1, // db_handle

false); // opened

entries.push_back(entry);