Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 11363215: Merge 134093 - MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop (Closed)

Created:
8 years, 1 month ago by karen
Modified:
8 years, 1 month ago
Reviewers:
tommyw
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 134093 - MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop https://bugs.webkit.org/show_bug.cgi?id=101586 Reviewed by Adam Barth. Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new API some WebCore objects might be cleaned away which is not allowed at this stage. This behaviour is not possible to test unfortunately in webkit. * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::stop): TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 1 month ago (2012-11-13 15:13:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698