Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11363189: Merge 133860 - User can change a disabled select (drop down box) (Closed)

Created:
8 years, 1 month ago by tkent
Modified:
8 years, 1 month ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 133860 - User can change a disabled select (drop down box) https://bugs.webkit.org/show_bug.cgi?id=100932 Patch by Kunihiko Sakamoto <ksakamoto@chromium.org>; on 2012-11-08 Reviewed by Kent Tamura. Source/WebCore: <select> should not handle events if it's disabled. Test: fast/forms/select/select-disabled.html * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): LayoutTests: Verify that keyboard events do not change value of disabled select. * fast/forms/select/select-disabled-expected.txt: Added. * fast/forms/select/select-disabled.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --2 lines) Patch
A + LayoutTests/fast/forms/select/select-disabled.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/select-disabled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLSelectElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
8 years, 1 month ago (2012-11-12 01:39:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698