Don't use drag to corner resizing for unresizable windows

ash/wm/workspace/workspace_window_resizer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_window_resizer.h"
 
 #include <algorithm>
 #include <cmath>
 #include <utility>
 #include <vector>
@@ skipping 18 matching lines @@
 #include "ui/compositor/layer.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/transform.h"
 
 namespace ash {
 
 scoped_ptr<WindowResizer> CreateWindowResizer(aura::Window* window,
                                               const gfx::Point& point_in_parent,
                                               int window_component) {
   DCHECK(window);
+  // No need to return a resizer when the window cannot get resized.
+  if (!wm::CanResizeWindow(window))

[sky, 2012/11/13 17:01:54]

Doesn't returning null here mean you can't drag from the caption at all? A
better place for this is in Details constructor. I believe if you set
is_resizable to false there when the window isn't resizable and the component
isn't the caption it'll take care of it.

[Mr4D (OOO till 08-26), 2012/11/13 21:27:23]

The suggestion to do this came from you ( :) ) - but - this is the way to go
since the is_resizable variable from details seems to be used to block
everything (bad naming? - see window_resizer.cc, line 174). To address your
concern I added another check for the hit test which seems to be the right thing
to do. Addressed.

+    return scoped_ptr<WindowResizer>();
+
   if (window->parent() &&
       window->parent()->id() == internal::kShellWindowId_WorkspaceContainer) {
     // Allow dragging maximized windows if it's not tracked by workspace. This
     // is set by tab dragging code.
     if (!wm::IsWindowNormal(window) &&
         (window_component != HTCAPTION || GetTrackedByWorkspace(window)))
       return scoped_ptr<WindowResizer>();
     return make_scoped_ptr<WindowResizer>(
         internal::WorkspaceWindowResizer::Create(window,
                                                  point_in_parent,
@@ skipping 230 matching lines @@
         ClearRestoreBounds(window());
       RestackWindows();
     }
     did_move_or_resize_ = true;
   }
 
   gfx::Point location_in_screen = location_in_parent;
   wm::ConvertPointToScreen(window()->parent(), &location_in_screen);
   const bool in_original_root =
       wm::GetRootWindowAt(location_in_screen) == window()->GetRootWindow();
+
   // Hide a phantom window for snapping if the cursor is in another root window.
-  if (in_original_root) {
+  if (in_original_root && wm::CanResizeWindow(window())) {
     UpdateSnapPhantomWindow(location_in_parent, bounds);
   } else {
     snap_type_ = SNAP_NONE;
     snap_phantom_window_controller_.reset();
   }
 
   if (!attached_windows_.empty())
     LayoutAttachedWindows(bounds);
   if (bounds != window()->bounds()) {
     bool destroyed = false;
@@ skipping 532 matching lines @@
   gfx::Rect layer_bounds = layer_->bounds();
   layer_bounds.set_origin(gfx::Point(0, 0));
   layer_->SetBounds(layer_bounds);
   layer_->SetVisible(false);
   // Detach it from the current container.
   layer_->parent()->Remove(layer_);
 }
 
 }  // namespace internal
 }  // namespace ash