Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4635)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/base/js2gtest.js

Issue 11363170: Add an accessibility audit test for WebUI pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Working test for a11y audit Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« .gitmodules ('K') | « chrome/js_unittest_vars.gypi ('k') | chrome/test/data/webui/a11y_audit_browsertest.h » ('j') | chrome/test/data/webui/a11y_audit_browsertest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/js2gtest.js
diff --git a/chrome/test/base/js2gtest.js b/chrome/test/base/js2gtest.js
index 9ec40a811cb06ccd5a2eca0be60cb1094c4bb111..35396d9b84b4c85fd57f6c64ffeeaa3707803f13 100644
--- a/chrome/test/base/js2gtest.js
+++ b/chrome/test/base/js2gtest.js
@@ -152,7 +152,8 @@ function TEST_F(testFixture, testFunction, testBody) {
var typedefCppFixture = this[testFixture].prototype.typedefCppFixture;
var isAsyncParam = testType === 'unit' ? '' :
this[testFixture].prototype.isAsync + ', ';
- var testShouldFail = this[testFixture].prototype.testShouldFail;
+ var testShouldFail = this[testFixture].prototype.testShouldFail ||
+ testFunction.match(/_shouldFail$/);
dmazzoni 2012/12/14 18:45:41 indentation?
aboxhall 2012/12/14 23:26:44 Ugh. Don't know how that happened. Done.
var testPredicate = testShouldFail ? 'ASSERT_FALSE' : 'ASSERT_TRUE';
var extraLibraries = genIncludes.concat(
this[testFixture].prototype.extraLibraries.map(
« .gitmodules ('K') | « chrome/js_unittest_vars.gypi ('k') | chrome/test/data/webui/a11y_audit_browsertest.h » ('j') | chrome/test/data/webui/a11y_audit_browsertest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698