Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5916)

Unified Diff: chrome/browser/ui/webui/web_ui_test_handler.cc

Issue 11363170: Add an accessibility audit test for WebUI pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: First, very incomplete pass at doing accessibility check in Javascript only Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/web_ui_test_handler.cc
diff --git a/chrome/browser/ui/webui/web_ui_test_handler.cc b/chrome/browser/ui/webui/web_ui_test_handler.cc
index cbb2d4249fe32184b902a111b42369698d83eddf..d3f91a93bb40b0a5a8c9883a562bb93661ba234c 100644
--- a/chrome/browser/ui/webui/web_ui_test_handler.cc
+++ b/chrome/browser/ui/webui/web_ui_test_handler.cc
@@ -75,6 +75,14 @@ void WebUITestHandler::HandleTestResult(const ListValue* test_result) {
ASSERT_TRUE(test_result->GetString(1, &message));
LOG(ERROR) << message;
}
+
+ if (test_result->GetSize() > 2) {
Sheridan Rawlins 2012/12/18 01:43:35 This won't be needed if you do the console.warn st
+ std::string a11y_message;
+ ASSERT_TRUE(test_result->GetString(2, &a11y_message));
+ LOG(ERROR) << a11y_message;
+ } else {
+ LOG(ERROR) << "a11y passed";
+ }
}
void WebUITestHandler::Observe(int type,

Powered by Google App Engine
This is Rietveld 408576698