chrome/test/data/webui/a11y_audit_browsertest.h - Issue 11363170: Add an accessibility audit test for WebUI pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/webui/a11y_audit_browsertest.h

Issue 11363170: Add an accessibility audit test for WebUI pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Working test for a11y audit Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Use of this source code is governed by a BSD-style license that can be

	2 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_TEST_DATA_WEBUI_A11Y_AUDIT_BROWSERTEST_H_

	6 #define CHROME_TEST_DATA_WEBUI_A11Y_AUDIT_BROWSERTEST_H_

	7

	8 #include "chrome/browser/ui/webui/web_ui_browsertest.h"

	9

	10 class WebUIA11yAuditTest : public WebUIBrowserTest {
	dmazzoni 2012/12/14 18:45:41 I'm thinking we should probably not use A11y in fi I'm thinking we should probably not use A11y in filenames or class names, it's not widely known enough. Feel free to use it in comments or variable names within an implementation class if you define it once at the top - but let's avoid it anywhere that non-accessibility developers are likely to run across frequently. Let me know if you see exceptions to this elsewhere in the codebase! aboxhall 2012/12/14 23:26:44 I'm happy to change the file name, but changing it Show quoted text On 2012/12/14 18:45:41, Dominic Mazzoni wrote: > I'm thinking we should probably not use A11y in filenames or class names, it's > not widely known enough. > > Feel free to use it in comments or variable names within an implementation class > if you define it once at the top - but let's avoid it anywhere that > non-accessibility developers are likely to run across frequently. > > Let me know if you see exceptions to this elsewhere in the codebase! I'm happy to change the file name, but changing it in the class name makes it eye-wateringly long. I've changed it for now, we can see what they look like side by side.
	11 public:

	12 WebUIA11yAuditTest();

	13 virtual ~WebUIA11yAuditTest();

	14

	15 };

	16

	17 #endif // CHROME_TEST_DATA_WEBUI_A11Y_AUDIT_BROWSERTEST_H_

OLD	NEW

« chrome/test/base/js2gtest.js ('K') | « chrome/test/base/js2gtest.js ('k') | chrome/test/data/webui/a11y_audit_browsertest.cc » ('j') | chrome/test/data/webui/a11y_audit_browsertest.cc » ('J')