Add an accessibility audit test for WebUI pages

chrome/browser/ui/webui/web_ui_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 28 matching lines @@
 #include "ui/base/resource/resource_handle.h"
 
 using content::NavigationController;
 using content::RenderViewHost;
 using content::WebContents;
 using content::WebUIController;
 using content::WebUIMessageHandler;
 
 namespace {
 
+const std::string kMockJSPath = "chrome/third_party/mock4js/mock4js.js";

[scr, 2012/12/07 06:11:35]

Would rather see FILE_PATH_LITERAL here and below.

[aboxhall, 2012/12/07 19:23:50]

Done.

 const FilePath::CharType kMockJS[] = FILE_PATH_LITERAL("mock4js.js");
+const std::string kA11yAuditLibraryJSPath =
+    "third_party/accessibility-developer-tools/gen/axs_testing.js";
 const FilePath::CharType kWebUILibraryJS[] = FILE_PATH_LITERAL("test_api.js");
 const FilePath::CharType kWebUITestFolder[] = FILE_PATH_LITERAL("webui");
 base::LazyInstance<std::vector<std::string> > error_messages_ =
     LAZY_INSTANCE_INITIALIZER;
 
 // Intercepts all log messages.
 bool LogHandler(int severity,
                 const char* file,
                 int line,
                 size_t message_start,
                 const std::string& str) {
   if (severity == logging::LOG_ERROR &&
       file &&
       std::string("CONSOLE") == file) {
     error_messages_.Get().push_back(str);
   }
 
   return false;
 }
 
 }  // namespace
 
 WebUIBrowserTest::~WebUIBrowserTest() {}
 
 void WebUIBrowserTest::AddLibrary(const FilePath& library_path) {
   user_libraries_.push_back(library_path);
 }
 
+void WebUIBrowserTest::AddLibraryFromUTFPath(const std::string path) {

[scr, 2012/12/07 06:11:35]

const FilePath& path?

[aboxhall, 2012/12/07 19:23:50]

Done.

+  FilePath filePath;
+  ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &filePath));
+  filePath = filePath.Append(FilePath::FromUTF8Unsafe(path));
+  AddLibrary(filePath);
+}
+
 bool WebUIBrowserTest::RunJavascriptFunction(const std::string& function_name) {
   ConstValueVector empty_args;
   return RunJavascriptFunction(function_name, empty_args);
 }
 
 bool WebUIBrowserTest::RunJavascriptFunction(const std::string& function_name,
                                              Value* arg) {
   ConstValueVector args;
   args.push_back(arg);
   return RunJavascriptFunction(function_name, args);
@@ skipping 235 matching lines @@
   test_data_directory_ = test_data_directory_.Append(kWebUITestFolder);
   ASSERT_TRUE(PathService::Get(chrome::DIR_GEN_TEST_DATA,
                                &gen_test_data_directory_));
 
   // TODO(dtseng): should this be part of every BrowserTest or just WebUI test.
   FilePath resources_pack_path;
   PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
   ResourceBundle::GetSharedInstance().AddDataPackFromPath(
       resources_pack_path, ui::SCALE_FACTOR_NONE);
 
-  FilePath mockPath;
-  ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &mockPath));
-  mockPath = mockPath.AppendASCII("chrome");
-  mockPath = mockPath.AppendASCII("third_party");
-  mockPath = mockPath.AppendASCII("mock4js");
-  mockPath = mockPath.Append(kMockJS);
-  AddLibrary(mockPath);
+  AddLibraryFromUTFPath(kMockJSPath);
   AddLibrary(FilePath(kWebUILibraryJS));
+  AddLibraryFromUTFPath(kA11yAuditLibraryJSPath);
 }
 
 void WebUIBrowserTest::TearDownInProcessBrowserTestFixture() {
+//  EXPECT_TRUE(RunJavascriptTest("runAccessibilityAudit"));

[scr, 2012/12/07 06:11:35]

Still needed?

[aboxhall, 2012/12/07 19:23:50]

Nope!

   InProcessBrowserTest::TearDownInProcessBrowserTestFixture();
   TestChromeWebUIControllerFactory::RemoveFactoryOverride(
       GURL(kDummyURL).host());
 }
 
 void WebUIBrowserTest::SetWebUIInstance(content::WebUI* web_ui) {
   override_selected_web_ui_ = web_ui;
 }
 
 WebUIMessageHandler* WebUIBrowserTest::GetMockMessageHandler() {
@@ skipping 345 matching lines @@
 // testDone directly and expect pass result.
 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPassesAsync) {
   ASSERT_TRUE(RunJavascriptAsyncTest("testDone"));
 }
 
 // Test that calling testDone during RunJavascriptTest still completes when
 // waiting for async result.
 IN_PROC_BROWSER_TEST_F(WebUIBrowserAsyncTest, TestTestDoneEarlyPasses) {
   ASSERT_TRUE(RunJavascriptTest("testDone"));
 }