ASan on Android requires -pie.

ASan on Android requires -pie.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166212

[Alexander Potapenko, 2012-11-06 16:00:31]

LGTM

On Tue, Nov 6, 2012 at 7:59 PM,  <eugenis@chromium.org> wrote:
> Reviewers: Alexander Potapenko, bulach,
>
> Description:
> ASan on Android requires -pie.
>
> Please review this at https://codereview.chromium.org/11363104/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>   M     build/common.gypi
>
>
> Index: build/common.gypi
> ===================================================================
> --- build/common.gypi   (revision 166200)
> +++ build/common.gypi   (working copy)
> @@ -2978,6 +2978,16 @@
>                    # Do not add any libraries after this!
>                    '<(android_ndk_lib)/crtend_android.o',
>                  ],
> +                'conditions': [
> +                  ['asan==1', {
> +                    'cflags': [
> +                      '-fPIE',
> +                    ],
> +                    'ldflags': [
> +                      '-pie',
> +                    ],
> +                  }],
> +                ],
>                }],
>                ['_type=="shared_library" or _type=="loadable_module"', {
>                  'ldflags': [
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[bulach, 2012-11-06 16:01:20]

lgtm, thanks!