Issue 11363098: Added quota_status_code.h/cc file to hold QuotaStatusCode enum and added function to convert enum t…

Issue 11363098: Added quota_status_code.h/cc file to hold QuotaStatusCode enum and added function to convert enum t… (Closed)

Created:
8 years, 1 month ago by calvinlo

Modified:
8 years, 1 month ago

Reviewers:
kinuko, benwells, nhiroki

CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added quota_status_code.h/cc file to hold QuotaStatusCode enum and added function to convert enum to error strings. BUG=156791 TBR=benwells@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166188

Patch Set 2 : Hiroki Review #1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -14 lines)			Patch
M	chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
A	webkit/quota/quota_status_code.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	webkit/quota/quota_status_code.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	webkit/quota/quota_types.h	View		2 chunks	+1 line, -11 lines	0 comments	Download
M	webkit/quota/webkit_quota.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

calvinlo

Hi benwells, can you please look at the small change in extension/ Kinuko and Hiroki, ...

8 years, 1 month ago (2012-11-06 08:29:36 UTC) #1

nhiroki

lgtm, please wait for kinuko's review. On 2012/11/06 08:29:36, calvinlo wrote: > Kinuko and Hiroki, ...

8 years, 1 month ago (2012-11-06 08:46:06 UTC) #2

calvinlo

http://codereview.chromium.org/11363098/diff/1/webkit/quota/webkit_quota.gypi File webkit/quota/webkit_quota.gypi (right): http://codereview.chromium.org/11363098/diff/1/webkit/quota/webkit_quota.gypi#newcode14 webkit/quota/webkit_quota.gypi:14: '../quota/quota_status_code.cc', On 2012/11/06 08:46:06, nhiroki wrote: > nit: can ...

8 years, 1 month ago (2012-11-06 08:48:41 UTC) #3

kinuko

lgtm > I'm also wondering if I should do > another CL to convert the ...

8 years, 1 month ago (2012-11-06 09:05:07 UTC) #4

calvinlo

Added TBR=benwells@ as I don't think the change to chrome/browser/extensions harmful.

8 years, 1 month ago (2012-11-06 09:37:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/11363098/3002

8 years, 1 month ago (2012-11-06 09:37:33 UTC) #6

Change committed as 166188

Expand Messages | Collapse Messages