Issue 11363071: Revert "Caches the display names in MultiDisplayManager."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363071: Revert "Caches the display names in MultiDisplayManager." (Closed)

Created:
8 years, 1 month ago by Paweł Hajdan Jr.

Modified:
8 years, 1 month ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Caches the display names in MultiDisplayManager." This reverts commit ecb62a0bbbdda8ad7b73b786ee4c7e1e766e498a. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165790

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -80 lines)			Patch
M	ash/ash_strings.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ash/display/multi_display_manager.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	ash/display/multi_display_manager.cc	View	5 chunks	+23 lines, -41 lines	0 comments	Download
M	ash/system/chromeos/tray_display.cc	View	4 chunks	+31 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

TBR 81>display\multi_display_manager.cc(538): error C3083: 'chromeos': the symbol to the left of a '::' must be ...

8 years, 1 month ago (2012-11-02 23:04:44 UTC) #1

Jun Mukai

8 years, 1 month ago (2012-11-02 23:05:09 UTC) #2

On 2012/11/02 23:04:44, Paweł Hajdan Jr. wrote:
> TBR
> 
> 81>display\multi_display_manager.cc(538): error C3083: 'chromeos': the symbol
to
> the left of a '::' must be a type
> 81>display\multi_display_manager.cc(538): error C2039: 'IsRunningOnChromeOS' :
> is not a member of 'base'
> 81>display\multi_display_manager.cc(538): error C3861: 'IsRunningOnChromeOS':
> identifier not found

thanks for revert.  lgtm...

Expand Messages | Collapse Messages