Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: lib/compiler/implementation/js/printer.dart

Issue 11363052: Rename regexp to reflect review feedback on semicolon change. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/js/printer.dart
diff --git a/lib/compiler/implementation/js/printer.dart b/lib/compiler/implementation/js/printer.dart
index 6f550254382e4a1fa31156805ea77b4d03c0ee47..87a4ffd89edc041a1b1ffca632b9288ed9295668 100644
--- a/lib/compiler/implementation/js/printer.dart
+++ b/lib/compiler/implementation/js/printer.dart
@@ -44,12 +44,12 @@ class Printer implements NodeVisitor {
void out(String str) {
if (str != "") {
- const identifierRegexp = const RegExp(r'^[a-zA-Z_0-9$]');
+ const identifierCharacterRegExp = const RegExp(r'^[a-zA-Z_0-9$]');
if (pendingSemicolon && (!shouldCompressOutput || str != "}")) {
outBuffer.add(";");
}
if (pendingSpace &&
- (!shouldCompressOutput || identifierRegexp.hasMatch(str))) {
+ (!shouldCompressOutput || identifierCharacterRegExp.hasMatch(str))) {
outBuffer.add(" ");
}
pendingSpace = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698