Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1136303003: Move hb_language_t determination outside of for loop (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
eae
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move hb_language_t determination outside of for loop Move hb_language_t determination outside of for loop, locale is constant here so it only has to be determined once. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 7 months ago (2015-05-14 21:32:00 UTC) #2
eae
Nice catch! LGTM
5 years, 7 months ago (2015-05-14 23:47:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136303003/1
5 years, 7 months ago (2015-05-14 23:47:36 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:01:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195384

Powered by Google App Engine
This is Rietveld 408576698