Issue 1136303003: Move hb_language_t determination outside of for loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136303003: Move hb_language_t determination outside of for loop (Closed)

Created:
5 years, 7 months ago by rwlbuis

Modified:
5 years, 7 months ago

Reviewers:
eae

CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Move hb_language_t determination outside of for loop Move hb_language_t determination outside of for loop, locale is constant here so it only has to be determined once. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195384

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/platform/fonts/shaping/HarfBuzzShaper.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136303003/1

5 years, 7 months ago (2015-05-14 23:47:36 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 01:01:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195384