Issue 1136293005: fixes #187, implicit html, as well as server messages not printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1136293005: fixes #187, implicit html, as well as server messages not printing (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly

Modified:
5 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fixes #187, implicit html, as well as server messages not printing R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/efb6dcdbda30f77e58c7c01ae65d2c658001228e

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
M	lib/devc.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/analysis_context.dart	View	1 chunk	+15 lines, -1 line	0 comments	Download
M	lib/src/options.dart	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

lgtm! https://codereview.chromium.org/1136293005/diff/1/lib/src/options.dart File lib/src/options.dart (right): https://codereview.chromium.org/1136293005/diff/1/lib/src/options.dart#newcode263 lib/src/options.dart:263: // TODO(jmesserly): shouldn't level always default to warning? ...

5 years, 7 months ago (2015-05-19 20:41:09 UTC) #3

Jennifer Messerly

5 years, 7 months ago (2015-05-19 20:44:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
efb6dcdbda30f77e58c7c01ae65d2c658001228e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages