Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1136283008: gpu: Cleanup 'gn check' errors for gpu_unittests target. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Cleanup 'gn check' errors for gpu_unittests target. Tested on Linux with the following command lines: $ gn gen out-gn/Debug $ gn check out-gn/Debug //gpu:* BUG=367595, 376000 TEST=see above R=sievers@chromium.org,dpranke@chromium.org TBR=brettw@chromium.org # for .gn Committed: https://crrev.com/f897224373ef523e12140f2268dd910bc91995ff Cr-Commit-Position: refs/heads/master@{#330165}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M .gn View 1 chunk +2 lines, -0 lines 2 comments Download
M gpu/BUILD.gn View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (1 generated)
tfarina
https://codereview.chromium.org/1136283008/diff/1/.gn File .gn (right): https://codereview.chromium.org/1136283008/diff/1/.gn#newcode48 .gn:48: "//gpu:*", My plan is to start adding the subdirectories ...
5 years, 7 months ago (2015-05-14 00:46:40 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/1136283008/diff/1/.gn File .gn (right): https://codereview.chromium.org/1136283008/diff/1/.gn#newcode48 .gn:48: "//gpu:*", On 2015/05/14 00:46:39, tfarina wrote: > My ...
5 years, 7 months ago (2015-05-14 01:32:39 UTC) #2
tfarina
Daniel, ping?
5 years, 7 months ago (2015-05-15 17:28:50 UTC) #3
no sievers
On 2015/05/15 17:28:50, tfarina wrote: > Daniel, ping? lgtm
5 years, 7 months ago (2015-05-15 17:50:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136283008/1
5 years, 7 months ago (2015-05-15 18:57:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 19:30:28 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:32:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f897224373ef523e12140f2268dd910bc91995ff
Cr-Commit-Position: refs/heads/master@{#330165}

Powered by Google App Engine
This is Rietveld 408576698