Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1136283007: Use base::StringPairs together with SplitStringIntoKeyValuePairs (Closed)

Created:
5 years, 7 months ago by packland
Modified:
5 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs together with SplitStringIntoKeyValuePairs BUG=412250 Committed: https://crrev.com/4d79d02a5c747a902d2acf87a8e401fe115b3216 Cr-Commit-Position: refs/heads/master@{#329712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/webui/fileicon_source.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
packland
Hello, please have a look. Thank you.
5 years, 7 months ago (2015-05-13 19:17:14 UTC) #2
xiyuan
lgtm
5 years, 7 months ago (2015-05-13 19:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136283007/1
5 years, 7 months ago (2015-05-13 19:49:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 20:50:54 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 20:52:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d79d02a5c747a902d2acf87a8e401fe115b3216
Cr-Commit-Position: refs/heads/master@{#329712}

Powered by Google App Engine
This is Rietveld 408576698