LayoutTests/fast/alignment/resources/alignment-parsing-utils.js - Issue 1136283006: [CSS Grid Layout] Avoid using StyleAdjuster to resolve 'auto' values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

Issue 1136283006: [CSS Grid Layout] Avoid using StyleAdjuster to resolve 'auto' values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed some layout tests failures. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/alignment/parse-justify-self-expected.txt ('k') | LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

diff --git a/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js b/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

index b97022a88c65762a347e2686428d51a24d38ed82..d853fb9dabe57bddb2a579e93bc8eae3d854f96b 100644

--- a/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

+++ b/LayoutTests/fast/alignment/resources/alignment-parsing-utils.js

@@ -33,14 +33,15 @@ function checkInheritValues(property, propertyID, value)

checkValues(element, property, propertyID, "inherit", value);

}

-function checkLegacyValues(property, propertyID, value)

+function checkLegacyValues(property, propertyID, value, computedValue)

{

var parentElement = document.createElement("div");

document.body.appendChild(parentElement);

- parentElement.style[property] = value;

- checkValues(parentElement, property, propertyID, value, value);

var element = document.createElement("div");

parentElement.appendChild(element);

- checkValues(element, property, propertyID, "", value);

+ parentElement.style[property] = value;

+ checkValues(parentElement, property, propertyID, value, value);

+ checkValues(element, property, propertyID, "", computedValue);

}