Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1136283002: qcms: Drop the google.patch file (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

qcms: Drop the google.patch file Rather than having a file that must be kept current with all changes to third_party/qcms/src highlight in the README.Chromium how the changes since the import can be readily seen. R=noel@chromium.org BUG=None TEST=None Committed: https://crrev.com/e0469a68bcc7a037f52642dae821ad05d9cf67d2 Cr-Commit-Position: refs/heads/master@{#329431}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Integrate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1703 lines) Patch
M third_party/qcms/README.chromium View 1 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/qcms/google.patch View 1 chunk +0 lines, -1699 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
robert.bradford
5 years, 7 months ago (2015-05-12 15:28:21 UTC) #1
Noel Gordon
LGTM https://codereview.chromium.org/1136283002/diff/1/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://codereview.chromium.org/1136283002/diff/1/third_party/qcms/README.chromium#newcode69 third_party/qcms/README.chromium:69: For the Chromium changes, since the import, in ...
5 years, 7 months ago (2015-05-12 17:04:43 UTC) #2
robert.bradford
https://codereview.chromium.org/1136283002/diff/1/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://codereview.chromium.org/1136283002/diff/1/third_party/qcms/README.chromium#newcode69 third_party/qcms/README.chromium:69: For the Chromium changes, since the import, in a ...
5 years, 7 months ago (2015-05-12 17:14:34 UTC) #3
Noel Gordon
OK. And wow, -1699 lines.
5 years, 7 months ago (2015-05-12 17:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136283002/20001
5 years, 7 months ago (2015-05-12 17:18:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 17:27:21 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 17:28:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0469a68bcc7a037f52642dae821ad05d9cf67d2
Cr-Commit-Position: refs/heads/master@{#329431}

Powered by Google App Engine
This is Rietveld 408576698